Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content/es/docs/debug-application-cluster/resource-metrics-pipeline.md #13648

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Add content/es/docs/debug-application-cluster/resource-metrics-pipeline.md #13648

merged 1 commit into from
Apr 10, 2019

Conversation

escalant3
Copy link
Contributor

Spanish translation for content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 6, 2019
@netlify
Copy link

netlify bot commented Apr 6, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 94258eb

https://deploy-preview-13648--kubernetes-io-master-staging.netlify.com

@netlify
Copy link

netlify bot commented Apr 6, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 352daff

https://deploy-preview-13648--kubernetes-io-master-staging.netlify.com

@escalant3
Copy link
Contributor Author

/assign @raelga

@escalant3
Copy link
Contributor Author

I signed it

@raelga
Copy link
Member

raelga commented Apr 7, 2019

@escalant3 don't worry, you need to wait some time before the @k8s-ci-robot is able to check the updated CLA status.

raelga
raelga reviewed Apr 7, 2019
View reviewed changes
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
electrocucaracha
electrocucaracha reviewed Apr 7, 2019
View reviewed changes
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Outdated

El Metrics Server se registró en la API principal del servidor a través del
[Kubernetes aggregator](/docs/concepts/api-extension/apiserver-aggregation/),
que fue introducido en Kubernetes 1.7.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/introducido/agregado

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No estoy seguro sobre ésta. La palabra agregado a continuación de aggregator puede ser confusa. Con el comentario de @raelga esto ya ha cambiado eliminando el que fue, que quizás sonaba más como una traducción directa.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot k8s-ci-robot added the language/es Issues or PRs related to Spanish language label Apr 9, 2019
@escalant3
Copy link
Contributor Author

Apologies about the number of changes. I guess I need to get familiar with the translation style we are aiming for.

@raelga
Copy link
Member

raelga commented Apr 9, 2019

No need to apology at all, we´re all learning together the best approach and style for the spanish documentation, really happy to have you on-board. 💪

There are only 2 things left:

  1. You need to sign the Linux Foundation CLA to be able to merge your contribution to master. You can find more information at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement.

  2. The new page is not integrated in the index, you will need to create the _index.html of the entire tree. For example:

$ tree tasks/
tasks/
├── _index.md
└── tools
    ├── _index.md
    └── install-kubectl.md

1 directory, 3 files

Otherwise the new page goes in the index top level as you can see in the preview.

Don't hesitate to reach me over slack if you have any issue with any of those points and thanks again for the localization!

@raelga
Copy link
Member

raelga commented Apr 9, 2019

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2019
@escalant3
Copy link
Contributor Author

This is how it looks with the _index.md files added.

image

@escalant3 escalant3 force-pushed the escalant3/es/resource-metrics-pipeline.md branch from 18cc8e6 to 6f674b4 Compare April 9, 2019 23:45
@escalant3 escalant3 force-pushed the escalant3/es/resource-metrics-pipeline.md branch from 6f674b4 to 352daff Compare April 9, 2019 23:51
@raelga
Copy link
Member

raelga commented Apr 10, 2019

Muchísimas gracias @escalant3!

/lgtm
/approve
 

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 76fc7aa into kubernetes:master Apr 10, 2019
emedina pushed a commit to emedina/website that referenced this pull request Apr 16, 2019
@escalant3
Create ES resource-metrics-pipeline.md (kubernetes#13648)
8711bab 
Add correct index file
McCoyAle pushed a commit to McCoyAle/website that referenced this pull request Apr 16, 2019
@escalant3 @McCoyAle
Create ES resource-metrics-pipeline.md (kubernetes#13648)
0eb4952 
Add correct index file
@raelga raelga changed the title Create ES resource-metrics-pipeline.md Add /es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Apr 19, 2019
@raelga raelga mentioned this pull request Apr 22, 2019
Closed
@raelga raelga changed the title Add /es/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md Add content/es/docs/debug-application-cluster/resource-metrics-pipeline.md Apr 22, 2019
@raelga raelga added this to the KubeCon EU 2019 milestone May 1, 2019
@raelga
Copy link
Member

raelga commented May 3, 2019

Tracked in #13948

nowjean pushed a commit to nowjean/website that referenced this pull request Jun 13, 2019
@escalant3 @nowjean
Create ES resource-metrics-pipeline.md (kubernetes#13648)
cb5840d 
Add correct index file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrocucaracha electrocucaracha electrocucaracha left review comments

@raelga raelga raelga left review comments

@glo-pena glo-pena Awaiting requested review from glo-pena

Assignees

@raelga raelga

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Spanish M1
Development

Successfully merging this pull request may close these issues.
4 participants
@escalant3 @k8s-ci-robot @raelga @electrocucaracha